linux-kernel - Re: [PATCH 1/2 RESEND] regulator: aat2870: Fix the logic of checking if no id is matched in aat2870_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1311955847.2712.12.camel@CNA0741383>
Date:	Fri, 29 Jul 2011 17:10:47 +0100
From:	Liam Girdwood <lrg@...com>
To:	"axel.lin@...il.com" <axel.lin@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jin Park <jinyoungp@...dia.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH 1/2 RESEND] regulator: aat2870: Fix the logic of
 checking if no id is matched in aat2870_get_regulator

On Fri, 2011-07-29 at 18:05 +0200, Axel Lin wrote:
> hi,
> Seems this 2 patches are not upstream. Should I resend it again?
> Regards,
> Axel

Not required atm thanks, this driver went via mfd so I can apply the fix
after the mfd merge or rc1.

Liam

> 
> 2011/7/7 Axel Lin <axel.lin@...il.com>:
> > In current implementation, the pointer ri is not NULL if no id is matched.
> > Fix it by checking i == ARRAY_SIZE(aat2870_regulators) if no id is matched.
> >
> > Signed-off-by: Axel Lin <axel.lin@...il.com>
> > Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> > ---
> >  drivers/regulator/aat2870-regulator.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/regulator/aat2870-regulator.c b/drivers/regulator/aat2870-regulator.c
> > index cd41045..11d1ab4 100644
> > --- a/drivers/regulator/aat2870-regulator.c
> > +++ b/drivers/regulator/aat2870-regulator.c
> > @@ -159,7 +159,7 @@ static struct aat2870_regulator *aat2870_get_regulator(int id)
> >                        break;
> >        }
> >
> > -       if (!ri)
> > +       if (i == ARRAY_SIZE(aat2870_regulators))
> >                return NULL;
> >
> >        ri->enable_addr = AAT2870_LDO_EN;
> > --
> > 1.7.4.1
> >
> >
> >
> >


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/