linux-kernel - Re: [PATCH v2 1/4] trace-cmd: Add parse error checking target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL26m8JXQxWf-Pj1_KuW=ORUoL9yzEdtgXnQfe7dw0cqPUSURw@mail.gmail.com>
Date:	Fri, 29 Jul 2011 12:07:38 -0700
From:	Vaibhav Nagarnaik <vnagarnaik@...gle.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] trace-cmd: Add parse error checking target

On Fri, Jul 29, 2011 at 10:53 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Fri, 2011-07-29 at 10:41 -0700, Vaibhav Nagarnaik wrote:
>
>> Thanks Steve. I will send the man page patch.
>
> BTW, I played with this and I have a few issues. I'll still accept the
> patch as it's not that big of a deal. But here's some improvements that
> can be made.
>
>
> It should load in the plugins. As the plugins can process failed events
> well. If you don't want the plugins than you can just do what we do with
> report, add a -N to prevent plugins from being loaded.

Thanks for the suggestion, I didn't know about plugins adding parsing
capability. I will add loading the available plugins for this option.

> It should also read a trace.dat file if one is provided on the command
> line. If you don't add a file then it will use the local events of the
> system, if possible.

Our intention with this patch was to reuse the format string parsing
functionality in trace-cmd to look for any errors in new trace events
added by various kernel developers. So this was targeted to test for
event format errors and report them during a new kernel release.

A trace.dat file has already recorded all the data from the machine and
when 'report' is used on it, the format string errors will be reported
regardless. I don't see how using 'check-events' on a trace.dat file
would be useful. Thoughts?

Vaibhav Nagarnaik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/