linux-kernel - Re: [PATCH] bnx2fc: use kthread_create_on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E33088A.80903@broadcom.com>
Date:	Fri, 29 Jul 2011 12:22:50 -0700
From:	"Bhanu Prakash Gollapudi" <bprakash@...adcom.com>
To:	"Eric Dumazet" <eric.dumazet@...il.com>
cc:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] bnx2fc: use kthread_create_on_node

On 7/29/2011 12:06 AM, Eric Dumazet wrote:
> Since bnx2fc_percpu_thread_create() creates percpu kthread, it makes
> sense to use kthread_create_on_node() to get proper NUMA affinity for
> kthread stack.
>
> Signed-off-by: Eric Dumazet<eric.dumazet@...il.com>
> CC: "James E.J. Bottomley"<JBottomley@...allels.com>

Thanks Eric.

Acked-by: Bhanu Prakash Gollapudi <bprakash@...adcom.com>

> ---
>   drivers/scsi/bnx2fc/bnx2fc_fcoe.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> index a97aff3..9843434 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c
> @@ -2161,9 +2161,9 @@ static void bnx2fc_percpu_thread_create(unsigned int cpu)
>
>   	p =&per_cpu(bnx2fc_percpu, cpu);
>
> -	thread = kthread_create(bnx2fc_percpu_io_thread,
> -				(void *)p,
> -				"bnx2fc_thread/%d", cpu);
> +	thread = kthread_create_on_node(bnx2fc_percpu_io_thread,
> +					(void *)p, cpu_to_node(cpu),
> +					"bnx2fc_thread/%d", cpu);
>   	/* bind thread to the cpu */
>   	if (likely(!IS_ERR(p->iothread))) {
>   		kthread_bind(thread, cpu);
>
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/