linux-kernel - Re: [tip:core/locking] lockdep: Fix lockdep_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E322B19.3020604@cn.fujitsu.com>
Date:	Fri, 29 Jul 2011 11:38:01 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	a.p.zijlstra@...llo.nl
CC:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:core/locking] lockdep: Fix lockdep_no_validate against IRQ
 states

tip-bot for Peter Zijlstra wrote:
> Commit-ID:  efbe2eee6dc0f179be84292bf269528b3ec365e9
> Gitweb:     http://git.kernel.org/tip/efbe2eee6dc0f179be84292bf269528b3ec365e9
> Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> AuthorDate: Thu, 7 Jul 2011 11:39:45 +0200
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Thu, 21 Jul 2011 20:43:16 +0200
> 
> lockdep: Fix lockdep_no_validate against IRQ states
> 
> Thomas noticed that a lock marked with lockdep_set_novalidate_class()
> will still trigger warnings for IRQ inversions. Cure this by skipping
> those when marking irq state.
> 
> Reported-and-tested-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Link: http://lkml.kernel.org/n/tip-2dp5vmpsxeraqm42kgww6ge2@git.kernel.org
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  kernel/lockdep.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> index 298c927..628276d 100644
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -2468,6 +2468,9 @@ mark_held_locks(struct task_struct *curr, enum mark_type mark)
>  
>  		BUG_ON(usage_bit >= LOCK_USAGE_STATES);
>  
> +		if (hlock_class(hlock)->key == &__lockdep_no_validate__)
> +			continue;
> +

The 2 pointers are not the same type.

kernel/lockdep.c: In function 'mark_held_locks':
kernel/lockdep.c:2471:31: warning: comparison of distinct pointer types lacks a cast

>  		if (!mark_lock(curr, hlock, usage_bit))
>  			return 0;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/