linux-kernel - Re: [PATCH] acerhdf.c: spaces in aliased changed to *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Jul 2011 23:55:58 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Anton V. Boyarshinov <boyarsh@...linux.org>
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] acerhdf.c: spaces in aliased changed to *

Hi,

Matthew, please apply, thanks.

Anton V. Boyarshinov writes:
> It seems that aliases shouldn't contain spaces, as 
> module-init-tools uses them as delimeters in module.alias file
> 
> Signed-off-by: Anton V. Boyarshinov <boyarsh@...linux.org>

Acked-by: Peter Feuerer <peter@...e.net>

> ---
>  drivers/platform/x86/acerhdf.c |   12 ++++++------
>  1 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index fca3489..7a8568b 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -703,15 +703,15 @@ MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Peter Feuerer");
>  MODULE_DESCRIPTION("Aspire One temperature and fan driver");
>  MODULE_ALIAS("dmi:*:*Acer*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1410*:");
> -MODULE_ALIAS("dmi:*:*Acer*:pnAspire 1810*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1410*:");
> +MODULE_ALIAS("dmi:*:*Acer*:pnAspire*1810*:");
>  MODULE_ALIAS("dmi:*:*Acer*:pnAO531*:");
>  MODULE_ALIAS("dmi:*:*Gateway*:pnAOA*:");
>  MODULE_ALIAS("dmi:*:*Gateway*:pnLT31*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnAOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOA*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMU*:");
> -MODULE_ALIAS("dmi:*:*Packard Bell*:pnDOTMA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnAOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOA*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMU*:");
> +MODULE_ALIAS("dmi:*:*Packard*Bell*:pnDOTMA*:");
>  
>  module_init(acerhdf_init);
>  module_exit(acerhdf_exit);
> -- 
> 1.7.2.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/