lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hd3gt636v.wl%tiwai@suse.de>
Date:	Fri, 29 Jul 2011 07:55:36 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	Jaroslav Kysela <perex@...ex.cz>, Liam Girdwood <lrg@...com>,
	Atsushi Nemoto <anemo@....ocn.ne.jp>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	linux-mips@...ux-mips.org
Subject: Re: [PATCH] SOUND: Fix txx9aclc.c build

At Thu, 28 Jul 2011 12:26:16 +0100,
Ralf Baechle wrote:
> 
> 552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
> pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:
> 
>   CC [M]  sound/soc/txx9/txx9aclc.o
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
> make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1
> 
> Fixed by providing a definition for card.
> 
> Signed-off-by: Ralf Baechle <ralf@...ux-mips.org>

Thanks, I applied now to fix/asoc branch of sound git tree.


Takashi

> 
>  sound/soc/txx9/txx9aclc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
> index 34aa972..3de99af 100644
> --- a/sound/soc/txx9/txx9aclc.c
> +++ b/sound/soc/txx9/txx9aclc.c
> @@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
>  
>  static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
>  {
> +	struct snd_card *card = rtd->card->snd_card;
>  	struct snd_soc_dai *dai = rtd->cpu_dai;
>  	struct snd_pcm *pcm = rtd->pcm;
>  	struct platform_device *pdev = to_platform_device(dai->platform->dev);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ