linux-kernel - Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1107301310070.4925@p34.internal.lan>
Date:	Sat, 30 Jul 2011 13:10:26 -0400 (EDT)
From:	Justin Piszcz <jpiszcz@...idpixels.com>
To:	Andreas Hartmann <andihartmann@...19freenet.de>
cc:	Stanislaw Gruszka <sgruszka@...hat.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Ivo van Doorn <IvDoorn@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	Alan Piszcz <ap@...arrain.com>,
	"users@...x00.serialmonkey.com" <users@...x00.serialmonkey.com>
Subject: Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure



On Sat, 30 Jul 2011, Justin Piszcz wrote:

>
>
> On Sat, 30 Jul 2011, Andreas Hartmann wrote:
>
>> Hi Justin,
>> 
>> if you want to test, if the module works stable, run this script for one
>> or two hours. It will stress the driver and the hardware.
>> 
>> If it doesn't crash and if the throughput is stable, you can hope, that
>> the driver is ok for daily work.
>> 
>> 
>> #!/bin/sh
>> 
>> dest="server" # set the servername
>> 
>> while true ; do
>> netperf -t TCP_MAERTS -H $dest
>> netperf -t TCP_STREAM -H $dest
>> netperf -t TCP_SENDFILE -H $dest
>> done
>> 
>> 
>> Start the script on the client. On the server start netserver.
>> You get netperf from http://www.netperf.org/netperf/
>> 
>> 
>> Andreas
>> 
>
> Hello Andreas,
>
> Thanks for the suggestion; however, it is crashing repeatedly after about 
> 5-10 minutes, so it is not needed yet.
>
> Here you go, crash 2:
> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p1.jpg
> http://home.comcast.net/~jpiszcz/20110730/2630-rt2800usb-crash2p2.jpg
>
> Justin.
>

(This is with the patch provided earlier)

atom:/usr/src/linux# cd drivers/net/wireless/rt2x00/
atom:/usr/src/linux/drivers/net/wireless/rt2x00# grep 'memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE)' rt2800lib.c
         memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE);
atom:/usr/src/linux/drivers/net/wireless/rt2x00# cat /usr/src/linux/.version
2
atom:/usr/src/linux/drivers/net/wireless/rt2x00# uname -a
Linux atom 3.0.0 #2 SMP Sat Jul 30 08:34:18 EDT 2011 x86_64 GNU/Linux
atom:/usr/src/linux/drivers/net/wireless/rt2x00#

Justin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/