linux-kernel - Re: [PATCH v1] Input: tegra-kbc - fix computation of polling time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110730190220.GA5686@core.coreip.homeip.net>
Date:	Sat, 30 Jul 2011 12:02:20 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Thierry Reding <thierry.reding@...onic-design.de>
Cc:	riyer@...dia.com, rydberg@...omail.se, olof@...om.net,
	amartin@...dia.com, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH v1] Input: tegra-kbc - fix computation of polling time

On Sat, Jul 30, 2011 at 12:41:01PM +0200, Thierry Reding wrote:
> * riyer@...dia.com wrote:
> > From: Rakesh Iyer <riyer@...dia.com>
> > 
> > Fix a constant definition and computation of polling time.
> > 
> > Signed-off-by: Rakesh Iyer <riyer@...dia.com>
> > ---
> >  drivers/input/keyboard/tegra-kbc.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> > index da3828f..263f6fc 100644
> > --- a/drivers/input/keyboard/tegra-kbc.c
> > +++ b/drivers/input/keyboard/tegra-kbc.c
> > @@ -37,7 +37,7 @@
> >  #define KBC_ROW_SCAN_DLY	5
> >  
> >  /* KBC uses a 32KHz clock so a cycle = 1/32Khz */
> > -#define KBC_CYCLE_USEC	32
> > +#define KBC_CYCLE_MS	32
> >  
> >  /* KBC Registers */
> >  
> > @@ -647,7 +647,7 @@ static int __devinit tegra_kbc_probe(struct platform_device *pdev)
> >  	debounce_cnt = min(pdata->debounce_cnt, KBC_MAX_DEBOUNCE_CNT);
> >  	scan_time_rows = (KBC_ROW_SCAN_TIME + debounce_cnt) * num_rows;
> >  	kbc->repoll_dly = KBC_ROW_SCAN_DLY + scan_time_rows + pdata->repeat_cnt;
> > -	kbc->repoll_dly = ((kbc->repoll_dly * KBC_CYCLE_USEC) + 999) / 1000;
> > +	kbc->repoll_dly = (kbc->repoll_dly + KBC_CYCLE_MS - 1) / KBC_CYCLE_MS;
> 
> You might want to consider using DIV_ROUND_UP for this.

Indeed. Adjusted locally and applied.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/