linux-kernel - Re: [patch] x86, x2apic: enable the bios request for x2apic optout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312067391.22074.58.camel@i7.infradead.org>
Date:	Sun, 31 Jul 2011 00:09:45 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Suresh Siddha <suresh.b.siddha@...el.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Song, Youquan" <youquan.song@...el.com>,
	"Mallick, Asit K" <asit.k.mallick@...el.com>,
	Prarit Bhargava <prarit@...hat.com>, trenn@...e.de
Subject: Re: [patch] x86, x2apic: enable the bios request for x2apic optout

On Fri, 2011-07-29 at 17:52 -0700, Suresh Siddha wrote:
> 
> +               WARN(!eim, KERN_WARNING "Your BIOS is broken and requested that"
> +                          " x2apic be disabled\n This will leave your machine"
> +                          " vulnerable to irq-injection attacks\n Use"
> +                          " 'intremap=no_x2apic_optout' to override BIOS "
> +                          "request\n"); 

Please don't break strings, except at the \n. I think checkpatch.pl even
has an exception to its 80-column rule for this, these days?

If I see this message and search in the kernel source for the string
'requested that x2apic be disabled', I should be able to find it.

-- 
dwmw2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/