linux-kernel - Re: [PATCH] virtio_blk: add block topology support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <871ux84bfp.fsf@rustcorp.com.au>
Date:	Sat, 30 Jul 2011 14:22:42 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Alexey Zaytsev <alexey.zaytsev@...il.com>
Cc:	Christoph Hellwig <hch@....de>,
	Christian Borntraeger <borntraeger@...ibm.com>,
	Avishay Traeger <avishay@...ibm.com>,
	linux-kernel@...r.kernel.org, Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH] virtio_blk: add block topology support

On Fri, 29 Jul 2011 22:09:49 +0300, Alexey Zaytsev <alexey.zaytsev@...il.com> wrote:
> VIRTIO_BLK_F_TOPOLOGY and VIRTIO_BLK_F_SECTOR_MAX features use the
> same bit, don't they?

Yes, spec bug.

> I guess you could just remove VIRTIO_BLK_F_SECTOR_MAX from the spec.
> Linux did not implement it, and virtualbox does not have virtio block
> support at all. Are there any other known users, who might have
> implemented the  VIRTIO_BLK_F_SECTOR_MAX feature?

Did qemu implement it?  If not, we'll simply kill it, and pretend it
never happened...

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/