linux-kernel - Re: Can you please take a look at bug39852?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20110730124644.GM2622@htj.dyndns.org>
Date:	Sat, 30 Jul 2011 14:46:44 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Peter Osterlund <peterosterlund2@...il.com>
Cc:	linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>
Subject: Re: Can you please take a look at bug39852?

(cc'ing Jens and LKML)

On Sat, Jul 30, 2011 at 02:38:26PM +0200, Peter Osterlund wrote:
> On Sat, 30 Jul 2011, Tejun Heo wrote:
> 
> >It looks like spurious lockdep warning via pkt_open().  Seems like the
> >problem has been there since the beginning.  What do you think?
> >
> > https://bugzilla.kernel.org/show_bug.cgi?id=39852
> 
> Yes, it is a spurious warning that has been there since the
> beginning. There were patches to silence the warning back in 2006
> 
> 	https://lkml.org/lkml/2006/7/25/41
> 
> but they were considered not the right approach. I don't know what
> the right approach is.

I see.  I think the proper solution would be adding a variant of
blkdev_get(), say blkdev_get_nested(), to give the inner open a
different locking class.  Jens, what do you think?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/