linux-kernel - Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E340A0C.5040604@gmail.com>
Date:	Sat, 30 Jul 2011 15:41:32 +0200
From:	Gertjan van Wingerde <gwingerde@...il.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
CC:	Larry Finger <Larry.Finger@...inger.net>,
	Justin Piszcz <jpiszcz@...idpixels.com>,
	Ivo van Doorn <IvDoorn@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	Alan Piszcz <ap@...arrain.com>,
	"users@...x00.serialmonkey.com" <users@...x00.serialmonkey.com>
Subject: Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

On 07/30/11 13:32, Stanislaw Gruszka wrote:
> We should clear skb->data not skb itself. Bug was introduced by:
> commit 0b8004aa12d13ec750d102ba4082a95f0107c649 "rt2x00: Properly
> reserve room for descriptors in skbs".
> 
> Cc: stable@...nel.org # 2.6.36+
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>

Ouch. Good catch. Let me go find a brown paper bag now :-(

Not sure if this is the source of Justin's problems, though.

Acked-by: Gertjan van Wingerde <gwingerde@...il.com>

> ---
>  drivers/net/wireless/rt2x00/rt2800lib.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
> index 75d2c6c..f94d669 100644
> --- a/drivers/net/wireless/rt2x00/rt2800lib.c
> +++ b/drivers/net/wireless/rt2x00/rt2800lib.c
> @@ -703,8 +703,7 @@ void rt2800_write_beacon(struct queue_entry *entry, struct txentry_desc *txdesc)
>  	/*
>  	 * Add space for the TXWI in front of the skb.
>  	 */
> -	skb_push(entry->skb, TXWI_DESC_SIZE);
> -	memset(entry->skb, 0, TXWI_DESC_SIZE);
> +	memset(skb_push(entry->skb, TXWI_DESC_SIZE), 0, TXWI_DESC_SIZE);
>  
>  	/*
>  	 * Register descriptor details in skb frame descriptor.


-- 
---
Gertjan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/