linux-kernel - Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110731164208.GP15795@trinity.fluff.org>
Date:	Sun, 31 Jul 2011 17:42:08 +0100
From:	Ben Dooks <ben-i2c@...ff.org>
To:	Paul Gortmaker <paul.gortmaker@...il.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-i2c@...r.kernel.org, akpm <akpm@...ux-foundation.org>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	khali@...ux-fr.org, ben-linux@...ff.org
Subject: Re: [PATCH -next] i2c: i2c-pxa-pci.c needs module.h

On Sat, Jul 30, 2011 at 03:09:32PM -0400, Paul Gortmaker wrote:
> On Sat, Jul 30, 2011 at 12:14 AM, Randy Dunlap <rdunlap@...otime.net> wrote:
> > From: Randy Dunlap <rdunlap@...otime.net>
> >
> > i2c-pxa-pci.c uses interfaces from linux/module.h, so it should
> > include that file.  This fixes build errors.
> 
> Applied to module.h-split, thanks.

ok, so I don't need to apply this one?
Acked-by: Ben Dooks <ben-linux@...ff.org>
 
> P.
> 
> >
> > Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> > ---
> >  drivers/i2c/busses/i2c-pxa-pci.c |    1 +
> >  1 file changed, 1 insertion(+)
> >
> > --- linux-next-20110729.orig/drivers/i2c/busses/i2c-pxa-pci.c
> > +++ linux-next-20110729/drivers/i2c/busses/i2c-pxa-pci.c
> > @@ -3,6 +3,7 @@
> >  * It does not support slave mode, the register slightly moved. This PCI
> >  * device provides three bars, every contains a single I2C controller.
> >  */
> > +#include <linux/module.h>
> >  #include <linux/pci.h>
> >  #include <linux/platform_device.h>
> >  #include <linux/i2c/pxa-i2c.h>
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-next" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/