linux-kernel - Re: [PATCH] staging; lirc, zilog: put_ir_rx may free 'rx' which can lead to double free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312116130.2271.8.camel@palomino.walls.org>
Date:	Sun, 31 Jul 2011 08:42:08 -0400
From:	Andy Walls <awalls@...metrocast.net>
To:	Dan Carpenter <error27@...il.com>, Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Jarod Wilson <jarod@...hat.com>,
	Jerome Brock <jbrock@...rs.sourceforge.net>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Gerd Knorr <kraxel@...dbach.in-berlin.de>,
	Jarod Wilson <jarod@...sonet.com>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Thomas Reitmayr <treitmayr@...oo.com>,
	Michal Kochanowicz <mkochano@....org.pl>,
	Christoph Bartelmus <lirc@...telmus.de>,
	Mark Weaver <mark@...l.co.uk>,
	Ulrich Mueller <ulrich.mueller42@....de>,
	Stefan Jahn <stefan@...c.org>
Subject: Re: [PATCH] staging; lirc, zilog: put_ir_rx may free 'rx' which can
 lead to double free

On Fri, 2011-07-29 at 09:08 +0300, Dan Carpenter wrote:
> On Thu, Jul 28, 2011 at 11:49:51PM +0200, Jesper Juhl wrote:
> > If calling put_ir_rx(rx, true); in
> > drivers/staging/lirc/lirc_zilog.c::ir_probe() returns true (1) then it
> > means that it has freed it's first argument. Subsequently jumping to
> > 'out_put_xx' will cause us to call put_ir_rx() once more since 'rx' is
> > not zero - leading to a double free.
> 
> It would be better to just remove the first call to put_ir_rx().

Jesper,

(Emails from you don't seem to make it to me, so I looked at your patch
in lkml.org archive.)

Good catch!

Although either fix will work, I do prefer Dan's suggested fix.  Could
you please implement that?

Since emails from you don't seem to make it to me, and since Dan's
suggestion is trivial to implement, I'll just ack that form of the fix
right now:

Acked-by: Andy Walls <awalls@...metrocast.net>

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/