linux-kernel - Re: v3.0: Weird kernel log message when resuming avout NMI received

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312200754.2617.454.camel@laptop>
Date:	Mon, 01 Aug 2011 14:12:34 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	Francis Moreau <francis.moro@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Don Zickus <dzickus@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	Ingo Molnar <mingo@...e.hu>, Jiri Slaby <jirislaby@...il.com>
Subject: Re: v3.0: Weird kernel log message when resuming avout NMI received

On Mon, 2011-08-01 at 15:21 +0400, Cyrill Gorcunov wrote:
> >       mutex_lock(&swhash->hlist_mutex);
> > -     if (swhash->hlist_refcount > 0) {
> > +     if (swhash->hlist_refcount > 0 && !swhash->swevent_hlist) {
> 
> Should not there be rcu_dereference(swhash->swevent_hlist)? 

swhash->hlist_mutex is the modifier lock for that rcu use and should
thus serialize things sufficiently.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/