linux-kernel - Re: [PATCH 6/8] staging: vme: rename *_slot_get to *_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110801123121.GA7130@becoht-mvanga>
Date:	Mon, 1 Aug 2011 14:31:21 +0200
From:	Manohar Vanga <manohar.vanga@...n.ch>
To:	Martyn Welch <martyn.welch@...com>
CC:	<gregkh@...e.de>, <cota@...ap.org>, <devel@...verdev.osuosl.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/8] staging: vme: rename *_slot_get to *_get_slot

Hi Martyn,

> If your doing vme_slot_get, then there's also vme_lm_get, vme_master_get and
> vme_slave_get.
> 
> Doing just this would then lead to more inconsistency in the naming and
> wouldn't even get rid of all the functions using the *_get naming convention.

I can simply change those as well and resend :)

> I'm not sure this change is worth it.

I thought it would be worth changing this especially with the addition of bridge
refcounting functions (which have the *_get/_set convention).

--
/manohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/