linux-kernel - Re: [PATCH 3/8] staging: vme: make [alloc|free]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E36B2AA.9060300@ge.com>
Date:	Mon, 01 Aug 2011 15:05:30 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	gregkh@...e.de, cota@...ap.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/8] staging: vme: make [alloc|free]_consistent bridge
 specific

On 01/08/11 15:00, Manohar Vanga wrote:
> Hi Martyn,
> 
>>> Make PCI dependent functions ([alloc|free]_consistent() in
>>> 'vme.c') bridge specific. By removing the dependency of the
>>> VME bridge framework on PCI, this patch allows for addition of
>>> non-PCI based VME bridges.
>>>
>>
>> I like the approach, I think I agree with Dan, I'd rather see the locking
>> inside the function for now.
> 
> Just noticed that the locking that Dan was referring to and the one you agree
> with in the previous patch ([PATCH 2/8] staging: vme: allow explicit assignment
> of bus numbers) and not this one. Which one are you referring to here?
> 

Whoops. Sorry, Dan's comment about the error printing, not the locking.

Martyn

-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@...com                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/