linux-kernel - Re: [PATCH] mrst_pmu: driver for Intel Moorestown Power Management Unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110801163938.74d03c2d@lxorguk.ukuu.org.uk>
Date:	Mon, 1 Aug 2011 16:39:38 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Len Brown <lenb@...nel.org>
Cc:	linux-pm@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mrst_pmu: driver for Intel Moorestown Power Management
 Unit

On Mon, 01 Aug 2011 11:24:45 -0400 (EDT)
Len Brown <lenb@...nel.org> wrote:

> 
> > > +	BUG_ON(pci_dev_num != mrst_devs[index].pci_dev_num);
> > 
> > That strikes me as needlessly unfriendly, you could warn/return NULL and
> > propogate a WARN_ONCE back to the user.
> 
> If a fit of friendlyness, I wrote the patch below.
> Let me know if it is not what you had in mind.

It's not so much the bug on as the fact it spews these if you boot it on
a non mrst box built with a generic kernel - which was the second part of
my comment and doesn't appear addressed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/