linux-kernel - Re: [PATCH] Remove remaining references of CONFIG_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110801083614.GC15578@n2100.arm.linux.org.uk>
Date:	Mon, 1 Aug 2011 09:36:14 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Zoltan Devai <zdevai@...il.com>
Cc:	linux-kernel@...r.kernel.org, chris@...kel.net,
	linux-am33-list@...hat.com, trivial@...nel.org,
	user-mode-linux-devel@...ts.sourceforge.net, cmetcalf@...era.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] Remove remaining references of CONFIG_GENERIC_TIME

On Sat, Jul 30, 2011 at 06:14:38PM +0200, Zoltan Devai wrote:
> Commit 592913ecb87a9e06f98ddb55b298f1a66bf94c6b has killed off any
> use of this config option long ago.

I don't see the point of this - we were free of GENERIC_TIME on ARM
shortly after it was originally killed off.  The problem is you can't
stop people introducing new uses of this - because it existed once and
there's nothing which errors out on its presence, people are going to
continue submitting patches with it in.  And it's going to continue
being missed at the review stage.

I've a similar problem with folk on ARM including mach/gpio.h as their
sole gpio header file rather than linux/gpio.h - I've been trying for
the last 1-2 years to educate people to use linux/ in preference.  You
can't do it, and I'm still just about the only one who picks up on that.
(SoC maintainers don't care.)  They will end up caring when I push a
change during the next merge window though, so I'll eventually stop
mach/gpio.h being included.  (Instead, it'll be asm/gpio.h).

GENERIC_TIME though... I don't think you'll ever stop new uses of it
creeping in unless you can arrange for something to error out.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/