linux-kernel - Re: [PATCH 7/11] arch/m32r/kernel/smp.c: trivial: use BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 02 Aug 2011 19:55:13 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	julia@...u.dk
CC:	takata@...ux-m32r.org, trivial@...nel.org,
	kernel-janitors@...r.kernel.org, akpm@...ux-foundation.org,
	benh@...nel.crashing.org, jesper.nilsson@...s.com,
	cmetcalf@...era.com, linux-m32r@...linux-m32r.org,
	linux-m32r-ja@...linux-m32r.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/11] arch/m32r/kernel/smp.c: trivial: use BUG_ON

(2011/08/02 19:35), Julia Lawall wrote:
> From: Julia Lawall <julia@...u.dk>
> 
> Use BUG_ON(x) rather than if(x) BUG();
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
> 
> @@ identifier x; @@
> -if (!x) BUG();
> +BUG_ON(!x);
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>

Indeed.
 Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


> 
> ---
>  arch/m32r/kernel/smp.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -u -p a/arch/m32r/kernel/smp.c b/arch/m32r/kernel/smp.c
> --- a/arch/m32r/kernel/smp.c
> +++ b/arch/m32r/kernel/smp.c
> @@ -327,8 +327,7 @@ void smp_flush_tlb_page(struct vm_area_s
>  	cpumask_clear_cpu(cpu_id, &cpu_mask);
>  
>  #ifdef DEBUG_SMP
> -	if (!mm)
> -		BUG();
> +	BUG_ON(!mm);
>  #endif
>  
>  	if (*mmc != NO_CONTEXT) {
> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/