| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1312284390-20244-1-git-send-email-LW@KARO-electronics.de> Date: Tue, 2 Aug 2011 13:26:30 +0200 From: Lothar Waßmann <LW@...O-electronics.de> To: linux-kernel@...r.kernel.org Cc: Jeremy Kerr <jeremy.kerr@...onical.com>, linux-arm-kernel@...ts.infradead.org, Lothar Waßmann <LW@...O-electronics.de> Subject: [BUGFIX][PATCH] Fix double inversion bug in clk_disable() The condition check for calling the low level disable function is wrong due to double inversion via '!' and '== 0'. Signed-off-by: Lothar Waßmann <LW@...O-electronics.de> --- drivers/clk/clk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 83c6b67..1525e2a 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -81,7 +81,7 @@ void clk_disable(struct clk *clk) WARN_ON(clk->enable_count == 0); - if (!--clk->enable_count == 0 && clk->ops->disable) + if (--clk->enable_count == 0 && clk->ops->disable) clk->ops->disable(clk); spin_unlock_irqrestore(&clk->enable_lock, flags); -- 1.5.6.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists