linux-kernel - Re: USB related "unable to handle kernel paging request" in 3.0.0-rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110802113554.GC4516@shale.localdomain>
Date:	Tue, 2 Aug 2011 14:35:54 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Florian Mickler <florian@...kler.org>
Cc:	linux-kernel@...r.kernel.org, Tino Keitel <tino.keitel@...ei.de>,
	mchehab@...radead.org
Subject: Re: USB related "unable to handle kernel paging request" in 3.0.0-rc7

On Tue, Aug 02, 2011 at 12:40:28PM +0200, Florian Mickler wrote:
> This should fix it. 
> 

That's not right.  You should just make .size_of_priv = 20 with a
comment.

Btw vp7045_properties is declared twice so it's confusing.  Initially,
I saw the first declaration so I thought .size_of_priv was zero.  I
don't understand why sparse doesn't warn about that.  Could you fix
that as well?

Also I did notice at first that you were the person who added the
.size_of_priv change so that's why I thought someone else must use
that function.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/