lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Aug 2011 15:38:27 -1000 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Al Viro <viro@...iv.linux.org.uk> Cc: "Rafael J. Wysocki" <rjw@...k.pl>, Josef Bacik <josef@...hat.com>, LKML <linux-kernel@...r.kernel.org>, Linux PM mailing list <linux-pm@...ts.linux-foundation.org>, Jan Kara <jack@...e.cz> Subject: Re: [Regression] Commit 02c24a82187d5a628c68edfe71ae60dc135cd178 breaks s2disk On Mon, Aug 1, 2011 at 3:30 PM, Al Viro <viro@...iv.linux.org.uk> wrote: > > Applied (in file->f_mapping variant; it is equal to bdev->bd_mapping, > but what's wrong with using ->f_mapping here?) My only issue was that from a "mindless conversion" standpoint, most of the other users had been changed to use inode->i_mapping. I dunno why. I agree that file->f_mapping looks cleaner and is what the code used to do. But maybe there was some reason why the other fsync methods had been changed to use filemap_write_and_wait_range(inode->i_mapping, start, end); instead. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists