linux-kernel - Re: [PATCH] rtl8192cu: add USB ID for Belkin n300 Micro USB wireless adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201108030035.50214.s.L-H@gmx.de>
Date:	Wed, 3 Aug 2011 00:35:48 +0200
From:	"Stefan Lippers-Hollmann" <s.L-H@....de>
To:	Larry Finger <Larry.Finger@...inger.net>
Cc:	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8192cu: add USB ID for Belkin n300 Micro USB wireless adapter

Hi

On Wednesday 03 August 2011, Larry Finger wrote:
> On 08/02/2011 03:43 PM, Stefan Lippers-Hollmann wrote:
> > On Tuesday 02 August 2011, Stefan Lippers-Hollmann wrote:
[...]
> >> +	{RTL_USB_DEVICE(0x050D, 0x2103, rtl92cu_hal_cfg)}, //Belkin - Edimax

Sorry about the C++ style comments, I meant to fix it, but forgot about
it in the end.

[...]
> > [1]	http://aptosid.com/index.php?name=PNphpBB2&file=viewtopic&t=1550&start=0
> > [2]	http://pastebin.com/ppZJ0GmU
> 
> I have been holding a few new ID's that are in the vendor driver awaiting a 
> test. These include the following:
> 
> +       {RTL_USB_DEVICE(USB_VENDER_ID_REALTEK, 0x817f, rtl92cu_hal_cfg)},
> +       {RTL_USB_DEVICE(0x13d3, 0x3357, rtl92cu_hal_cfg)}, /* AzureWave */
> +       {RTL_USB_DEVICE(0x13d3, 0x3358, rtl92cu_hal_cfg)}, /*Azwave 8188CE-VAU*/
> -       {RTL_USB_DEVICE(0x3359, 0x13d3, rtl92cu_hal_cfg)},
> +       {RTL_USB_DEVICE(0x13d3, 0x3359, rtl92cu_hal_cfg)},
> +       {RTL_USB_DEVICE(0x4855, 0x0090, rtl92cu_hal_cfg)}, /* Feixun */
> +       {RTL_USB_DEVICE(0x4855, 0x0091, rtl92cu_hal_cfg)}, /* NetweeN-Feixun */
> +       {RTL_USB_DEVICE(0x9846, 0x9041, rtl92cu_hal_cfg)}, /* Netgear Cameo */
> +       {RTL_USB_DEVICE(0x050d, 0x2102, rtl92cu_hal_cfg)}, /*Belkin-Sercomm*/
> +       {RTL_USB_DEVICE(0x050d, 0x2103, rtl92cu_hal_cfg)}, /*Belkin-Edimax*/
> 
> The deleted entry has the vendor and product reversed. The first one in the list 
> has been tested and works.
> 
> Based on your report, I will drop the 050d entries. If you get a confirmation 
> that 050d,2103 works, then submit that patch.

I have now asked the reporter to check the state of rtl8192cu again, 
current state is (with a kernel including my original patch):
- functionality confirmed on an unencrypted network
- WPA2-psk not conclusively tested, it may be out of range for his device.
("EDIT: With my netbook I can get an IP address and use the neighbor's
  unsecured network. Also, the Belkin device reports it at -47 dBm 
  signal strength, but my Toshiba netbook gives it -80 to -83 (which 
  may explain why the Belkin couldn't get an IP address), so there are 
  still some issues to sort.")
- no Oops if his USB ID is compiled into the module, that only happens
  if he tries to inject it into an unpatched kernel with:
  echo -n "050d 2103">  /sys/bus/usb/drivers/rtl8192cu/new_id
  (and I'm reluctant to raise this as potential issue completely, due
  to the tainted kernel condition on his system).

Hopefully he'll answer my further inquiries about the stability of his 
Belkin n300 Micro USB soon.

Regards
	Stefan Lippers-Hollmann
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/