[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAC5umyiotpqLv9Oz=+Mr0csdNZe=8WJvj0qW2g8fAmvSX3-_Sw@mail.gmail.com>
Date: Tue, 2 Aug 2011 16:35:05 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: Pavel Machek <pavel@....cz>
Cc: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH v3 0/6] notifier error injection
2011/8/1 Pavel Machek <pavel@....cz>:
> Hi!
>
>> This provides kernel modules that can be used to test the error handling
>> of notifier call chain failures by injecting artifical errors to the
>> following notifier chain callbacks.
>>
>> * CPU notifier
>> * PM notifier
>> * memory hotplug notifier
>> * powerpc pSeries reconfig notifier
> ...
>
>> 11 files changed, 680 insertions(+), 38 deletions(-)
>
> Do we really need this debugging code in mainline? How many bugs did
> it find?
I'm seeing a memory hotplug related bug but it also can be reproducible
without this feature. Repeatedly online/offline memory with attached
memory-hotplug.sh under disk activity like kernel build can easily cause
Oopses.
Aside from that, I didn't find any bugs but I still think this feature is
useful for testing and it just add a little complexity to exiting code.
(Maybe I need to prove it by finding more bugs)
Download attachment "memory-hotplug.sh" of type "application/x-sh" (1952 bytes)
Download attachment "messages" of type "application/octet-stream" (14650 bytes)
Powered by blists - more mailing lists