lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20110802075728.GA9553@opensource.wolfsonmicro.com>
Date:	Tue, 2 Aug 2011 16:57:29 +0900
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Anuj Aggarwal <anuj.aggarwal@...com>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH] regulator: tps65023: Remove num_voltages array

On Tue, Aug 02, 2011 at 03:48:30PM +0800, Axel Lin wrote:

> @@ -519,12 +515,14 @@ static const struct tps_info tps65023_regs[] = {
>  		.name = "VDCDC2",
>  		.min_uV =  3300000,
>  		.max_uV = 3300000,
> +		.table_len = 0,
>  		.fixed = 1,
>  	},
>  	{
>  		.name = "VDCDC3",
>  		.min_uV =  1800000,
>  		.max_uV = 1800000,
> +		.table_len = 0,
>  		.fixed = 1,

No need to explicitly set things to zero, it's the default for things
declared static.  If this isn't declared static then it should be.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ