linux-kernel - Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110803183349.GA5956@redhat.com>
Date:	Wed, 3 Aug 2011 20:33:50 +0200
From:	Stanislaw Gruszka <sgruszka@...hat.com>
To:	Justin Piszcz <jpiszcz@...idpixels.com>
Cc:	Andreas Hartmann <andihartmann@...19freenet.de>,
	Larry Finger <Larry.Finger@...inger.net>,
	Ivo van Doorn <IvDoorn@...il.com>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
	Alan Piszcz <ap@...arrain.com>,
	"users@...x00.serialmonkey.com" <users@...x00.serialmonkey.com>
Subject: Re: [PATCH] rt2x00: rt2800: fix zeroing skb structure

On Wed, Aug 03, 2011 at 01:44:10PM -0400, Justin Piszcz wrote:
> Tested that patch:
> 
> 1. The driver no longer automatically loads, I had to manually modprobe it.
This must be some other problem not related with patch.

> 2. After loading, I get this (keep getting these)
> 
> [  384.054538] phy0 -> rt2800_txdone: Error - Data pending
> [  384.072773] phy0 -> rt2800_txdone: Error - Data pending
> [  384.096545] phy0 -> rt2800_txdone: Error - Data pending
> [  384.117301] phy0 -> rt2800_txdone: Error - Data pending
> [  384.537586] phy0 -> rt2800_txdone: Error - Data pending
> [  384.555716] phy0 -> rt2800_txdone: Error - Data pending
> [  384.573903] phy0 -> rt2800_txdone: Error - Data pending
> [  384.599465] phy0 -> rt2800_txdone: Error - Data pending
> [  384.618523] phy0 -> rt2800_txdone: Error - Data pending
You can remove line

ERROR(rt2x00dev, "Data pending\n");

from rt2800_txdone to stop seeing this. It's kinda interesting
how frequent this happens.

> No crash yet, but bad ping again too (always with the rt2800usb) driver:
> 
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=1 ttl=64 time=53.1 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=2 ttl=64 time=285 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=3 ttl=64 time=89.6 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=4 ttl=64 time=120 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=5 ttl=64 time=42.2 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=6 ttl=64 time=156 ms
> 64 bytes from atomw.internal.lan (192.168.0.2): icmp_req=7 ttl=64 time=77.2 ms

I think patch could have site effect to not run tx queue while we have pending
data on it. Do you have such ping times always (i.e. after a 5 minutes, 10
minutes, 20  ... ) or just randomly?

Stanislaw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/