linux-kernel - Re: [PATCH -next] tpm_tis: fix build when ACPI is not enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110803185634.GA16988@elte.hu>
Date:	Wed, 3 Aug 2011 20:56:34 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Leendert van Doorn <leendert@...son.ibm.com>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	tpmdd-devel@...ts.sourceforge.net,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH -next] tpm_tis: fix build when ACPI is not enabled


* Randy Dunlap <rdunlap@...otime.net> wrote:

> From: Randy Dunlap <rdunlap@...otime.net>
> 
> Fix tpm_tis.c build when CONFIG_ACPI is not enabled by providing
> a stub function.  Fixes many build errors/warnings:
> 
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of '__mptr'
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: error: dereferencing pointer to incomplete type
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:89: error: request for member 'list' in something not a structure or union
> drivers/char/tpm/tpm_tis.c:89: warning: type defaults to 'int' in declaration of 'type name'
> drivers/char/tpm/tpm_tis.c:90: error: dereferencing pointer to incomplete type
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
> Cc: Leendert van Doorn <leendert@...son.ibm.com>
> ---
>  drivers/char/tpm/tpm_tis.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

FYI, this build breakage is now upstream as well and triggers easily.

This fix was sent 5+ days ago (with still no reply to it), a day 
after this fix the security tree pull request was sent with this 
known build breakage included, so the bug is still unfixed upstream 
and no fix is in the pipeline AFAICS. Got lost?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/