linux-kernel - linux-next: build failure after merge of the moduleh tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20110803141013.2ca5285e5b13a837fcf2c763@canb.auug.org.au>
Date:	Wed, 3 Aug 2011 14:10:13 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Thornber <thornber@...hat.com>,
	Mike Snitzer <snitzer@...hat.com>,
	Alasdair G Kergon <agk@...hat.com>
Subject: linux-next: build failure after merge of the moduleh tree

Hi Paul,

After merging the moduleh tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:137:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:143:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:158:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:169:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:292:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:303:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:402:1: warning: parameter names (without types) in function declaration
drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: data definition has no type or storage class
drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
drivers/md/persistent-data/dm-transaction-manager.c:413:1: warning: parameter names (without types) in function declaration

Caused by an interaction between the module.h split and commit
90616764c64f ("The persistent-data library offers a re-usable framework
for the storage").

I have applied the below patch for today.  This file should really have
included module.h anyway ...

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Wed, 3 Aug 2011 14:06:38 +1000
Subject: [PATCH] dm: dm-transaction-manager.c needs export.h

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 .../md/persistent-data/dm-transaction-manager.c    |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/md/persistent-data/dm-transaction-manager.c b/drivers/md/persistent-data/dm-transaction-manager.c
index 4284921..bf9b61b 100644
--- a/drivers/md/persistent-data/dm-transaction-manager.c
+++ b/drivers/md/persistent-data/dm-transaction-manager.c
@@ -10,6 +10,7 @@
 #include "dm-persistent-data-internal.h"
 
 #include <linux/slab.h>
+#include <linux/export.h>
 #include <linux/device-mapper.h>
 
 #define DM_MSG_PREFIX "transaction manager"
-- 
1.7.5.4

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/