linux-kernel - Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg from void * to journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Aug 2011 07:38:43 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Li Zefan <lizf@...fujitsu.com>
cc:	Wang Sheng-Hui <shhuiw@...il.com>, Theodore Ts'o <tytso@....edu>,
	Jan Kara <jack@...e.cz>, linux-ext4@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jbd/jbd2: add pointer type conversion on void *arg from
 void * to journal_t * explicitly in kjournald/kjournald2

On Wed, 3 Aug 2011, Li Zefan wrote:

> 09:58, Wang Sheng-Hui wrote:
> > The patch is against 3.0
> > 
> > The arg of kjournald/kjournald2 is void *, and points to type
> > journal_t. We should convert it to journal_t * explicitly in
> > the kjournald/kjournald2 function body.
> > 
> 
> Why?
> 
> Implicit convertion from void * to foo * is ok. Did the compiler
> complain about this to you?
> 

Not only is it perfectly OK to rely on the implicit conversion, a lot of 
work has gone into actively removing such unneeded explicit casts over the 
years, so let's not introduce new ones.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/