linux-kernel - Re: [PATCH v2 08/12] KVM: MMU: fast prefetch spte on invlpg path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E38E4A2.4080705@cn.fujitsu.com>
Date:	Wed, 03 Aug 2011 14:03:14 +0800
From:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
CC:	Avi Kivity <avi@...hat.com>, LKML <linux-kernel@...r.kernel.org>,
	KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 08/12] KVM: MMU: fast prefetch spte on invlpg path

On 08/03/2011 02:36 AM, Marcelo Tosatti wrote:

>>  	mask.cr0_wp = mask.cr4_pae = mask.nxe = 1;
>> diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
>> index 0f915b5..3466229 100644
>> --- a/arch/x86/kvm/paging_tmpl.h
>> +++ b/arch/x86/kvm/paging_tmpl.h
>> @@ -666,20 +666,22 @@ static void FNAME(invlpg)(struct kvm_vcpu *vcpu, gva_t gva)
>>  {
>>  	struct kvm_shadow_walk_iterator iterator;
>>  	struct kvm_mmu_page *sp;
>> -	gpa_t pte_gpa = -1;
>>  	int level;
>>  	u64 *sptep;
>>  
>>  	vcpu_clear_mmio_info(vcpu, gva);
>> +	mmu_topup_memory_caches(vcpu);
> 
> Should handle failure.
> 

Yes, thanks Marcelo! I will fix it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/