lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1312351854.26546.9.camel@Joe-Laptop>
Date:	Tue, 02 Aug 2011 23:10:53 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH] Staging: comedi: fix printk issue in pcl818.c

On Wed, 2011-08-03 at 10:54 +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@...enturtles.in>
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool

This patch does a lot more than fix a printk warning.

Please make your patch descriptions match your patch.

>  drivers/staging/comedi/drivers/pcl818.c |  118 +++++++++++++++----------------

> @@ -1461,7 +1452,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
>  	struct comedi_cmd *cmd = &s->async->cmd;
>  	int retval;
>  
> -	printk("pcl818_ai_cmd()\n");
> +	dev_dbg(dev->hw_dev "pcl818_ai_cmd()\n");

Compile your patches _before_ sending them.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ