linux-kernel - Re: linux-next: build failure after merge of the final tree (devicetree tree related)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110804.011749.451093446187764463.davem@davemloft.net>
Date:	Thu, 04 Aug 2011 01:17:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	grant.likely@...retlab.ca
Cc:	sfr@...b.auug.org.au, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, shawn.guo@...aro.org,
	torvalds@...ux-foundation.org
Subject: Re: linux-next: build failure after merge of the final tree
 (devicetree tree related)

From: David Miller <davem@...emloft.net>
Date: Thu, 04 Aug 2011 00:13:14 -0700 (PDT)

> I think this change was stillborn when you committed it and you should
> have reviewed it more thoroughly and pushed back.

I also took a look at the one driver that's using this new interface,
and I have more disagreements.

The alias lookup unconditionally creates new aliases for the given
node and passes back an integer ID.

So even though it is implicitly creating properties, it doesn't update
the in-kernel device tree nor does it update the OpenFirmware
etc. copy.

This behvaior is undesirable and makes no sense.  This IMX serial
driver merely wants increasing incrementing indexes for the serial
nodes it finds, and there are much better ways to do that.

It also wants to see if device tree aliases have explicit port
settings, and that's fine.  The new alias code can help it do this,
but it doesn't need to create new fake aliases in order to accomplish
that task.

This stuff needs more work, I would like to suggest that you just
revert at this point.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/