linux-kernel - Re: [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312446527.1539.2.camel@vkoul-udesk3>
Date:	Thu, 04 Aug 2011 13:58:47 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	linus.walleij@...aro.org, pratyush.anand@...com,
	rajeev-dlh.kumar@...com, linux@....linux.org.uk,
	bhupesh.sharma@...com, shiraz.hashim@...com,
	linux-kernel@...r.kernel.org, vipin.kumar@...com,
	armando.visconti@...com, amit.virdi@...com,
	vipulkumar.samar@...com, viresh.linux@...il.com,
	deepak.sikri@...com, dan.j.williams@...el.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to
 dev_dbg from dev_info

On Mon, 2011-08-01 at 15:07 +0530, Viresh Kumar wrote:
> For 8 memory and 16 slave channels 35 boot print lines are printed. And that is
> too much. Most of this would be more useful for debugging. So moving few of them
> to dev_dbg instead of dev_info. Now only 3 prints will be printed.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/dma/amba-pl08x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index 6c52959..3fbaf0e 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1717,7 +1717,7 @@ static int pl08x_dma_init_virtual_channels(struct pl08x_driver_data *pl08x,
>  			kfree(chan);
>  			continue;
>  		}
> -		dev_info(&pl08x->adev->dev,
> +		dev_dbg(&pl08x->adev->dev,
>  			 "initialize virtual channel \"%s\"\n",
>  			 chan->name);
>  
> @@ -1945,7 +1945,7 @@ static int pl08x_probe(struct amba_device *adev, const struct amba_id *id)
>  		spin_lock_init(&ch->lock);
>  		ch->serving = NULL;
>  		ch->signal = -1;
> -		dev_info(&adev->dev,
> +		dev_dbg(&adev->dev,
>  			 "physical channel %d is %s\n", i,
>  			 pl08x_phy_channel_busy(ch) ? "BUSY" : "FREE");
>  	}
ahh, this looks ugly, can you pls fix the print to make them look
better. Single line or fmt string is one line should be ok, arg can be
moved to second.

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/