linux-kernel - Re: [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312448020.1539.25.camel@vkoul-udesk3>
Date:	Thu, 04 Aug 2011 14:23:40 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	viresh kumar <viresh.kumar@...com>
Cc:	Pratyush ANAND <pratyush.anand@...com>,
	Rajeev KUMAR <rajeev-dlh.kumar@...com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	Bhupesh SHARMA <bhupesh.sharma@...com>,
	Armando VISCONTI <armando.visconti@...com>,
	"linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Vipin KUMAR <vipin.kumar@...com>,
	Shiraz HASHIM <shiraz.hashim@...com>,
	Amit VIRDI <Amit.VIRDI@...com>,
	Vipul Kumar SAMAR <vipulkumar.samar@...com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	Deepak SIKRI <deepak.sikri@...com>,
	"dan.j.williams@...el.com" <dan.j.williams@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to
 dev_dbg from dev_info

On Thu, 2011-08-04 at 14:55 +0530, viresh kumar wrote:
> On 08/04/2011 01:58 PM, Koul, Vinod wrote:
> >> > +		dev_dbg(&adev->dev,
> >> >  			 "physical channel %d is %s\n", i,
> >> >  			 pl08x_phy_channel_busy(ch) ? "BUSY" : "FREE");
> >> >  	}
> > ahh, this looks ugly, can you pls fix the print to make them look
> > better. Single line or fmt string is one line should be ok, arg can be
> > moved to second.
> 
> Just to check if I understood your suggestion correctly, you want this:
> 
> 		dev_dbg(&adev->dev, "physical channel %d is %s\n",
> 			i, pl08x_phy_channel_busy(ch) ? "BUSY" : "FREE");
> 
> Surely that will be done.
> 

Much better :)
-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/