[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1312490574-14804-1-git-send-email-prtvar.b@gmail.com>
Date: Thu, 4 Aug 2011 22:42:54 +0200
From: Bojan Prtvar <prtvar.b@...il.com>
To: jkosina@...e.cz
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org, Bojan Prtvar <prtvar.b@...il.com>
Subject: [PATCH 1/2] HID: kfree() NULL pointer cleanup
Checking for NULL pointers before kfree() is redundant.
Signed-off-by: Bojan Prtvar <prtvar.b@...il.com>
---
drivers/hid/hid-prodikeys.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-prodikeys.c b/drivers/hid/hid-prodikeys.c
index 158b389..62f95d4 100644
--- a/drivers/hid/hid-prodikeys.c
+++ b/drivers/hid/hid-prodikeys.c
@@ -849,9 +849,7 @@ static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
err_stop:
hid_hw_stop(hdev);
err_free:
- if (pm != NULL)
- kfree(pm);
-
+ kfree(pm);
kfree(pk);
return ret;
}
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists