linux-kernel - Re: [PATCH 2/2] HID: kfree() NULL pointer cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1108042346450.32288@pobox.suse.cz>
Date:	Thu, 4 Aug 2011 23:46:54 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bojan Prtvar <prtvar.b@...il.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] HID: kfree() NULL pointer cleanup

On Thu, 4 Aug 2011, Bojan Prtvar wrote:

> Checking for NULL pointers before kfree() is redundant.
> 
> Signed-off-by: Bojan Prtvar <prtvar.b@...il.com>
> ---
>  drivers/hid/hid-zydacron.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/hid/hid-zydacron.c b/drivers/hid/hid-zydacron.c
> index e903715..1ad85f2 100644
> --- a/drivers/hid/hid-zydacron.c
> +++ b/drivers/hid/hid-zydacron.c
> @@ -201,9 +201,7 @@ static void zc_remove(struct hid_device *hdev)
>  	struct zc_device *zc = hid_get_drvdata(hdev);
>  
>  	hid_hw_stop(hdev);
> -
> -	if (NULL != zc)
> -		kfree(zc);
> +	kfree(zc);
>  }

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/