linux-kernel - Re: linux-next: Tree for Aug 4 (zcache)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110804215412.GE2919@nautilus.holoscopio.com>
Date:	Thu, 4 Aug 2011 18:54:13 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Greg KH <greg@...ah.com>, Stephen Rothwell <sfr@...b.auug.org.au>,
	Dan Magenheimer <dan.magenheimer@...cle.com>,
	driverdevel <devel@...verdev.osuosl.org>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Nitin Gupta <ngupta@...are.org>
Subject: Re: linux-next: Tree for Aug 4 (zcache)

On Thu, Aug 04, 2011 at 02:51:45PM -0700, Randy Dunlap wrote:
> On Thu, 4 Aug 2011 14:44:41 -0700 Greg KH wrote:
> 
> > On Thu, Aug 04, 2011 at 02:24:37PM -0700, Randy Dunlap wrote:
> > > On Thu, 4 Aug 2011 14:58:34 +1000 Stephen Rothwell wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Just in case anyone needs reminding:  Please do not add anything destined
> > > > for v3.2 into linux-next included trees until after v3.1-rc1.
> > > 
> > > 
> > > on i386:
> > > 
> > > drivers/built-in.o: In function `zcache_pampd_create':
> > > zcache-main.c:(.text+0x159b8f): undefined reference to `__udivdi3'
> > 
> > Very wierd, what would cause that?
> 
> I don't see what's weird about it.
> 
> Probably one of these divisions:
> 
> 		if (curr_pers_pampd_count >
> 		    (zv_page_count_policy_percent * totalram_pages) / 100)
> 			goto out;
> 
> or
> 
> 			zv_mean_zsize = xv_get_total_size_bytes(cli->xvpool) /
> 						curr_pers_pampd_count;
> 

The second one. xv_get_total_size_bytes returns u64. I am just
compile-testing a fix.

> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)