linux-kernel - Re: [PATCH] nbd: nbd sysfs framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAECXXi5pkRAY_dVSwSUrj5RQzsJ2YVx6xXovzpuRDOEOq92s9g@mail.gmail.com>
Date:	Wed, 3 Aug 2011 22:17:04 -0400
From:	Paul Clements <paul.clements@...sios.com>
To:	Greg KH <greg@...ah.com>
Cc:	andrew morton <akpm@...ux-foundation.org>,
	kernel list <linux-kernel@...r.kernel.org>,
	nbd-general@...ts.sourceforge.net
Subject: Re: [PATCH] nbd: nbd sysfs framework

On Wed, Aug 3, 2011 at 7:34 PM, Greg KH <greg@...ah.com> wrote:
> On Wed, Aug 03, 2011 at 07:15:51PM -0400, Paul Clements wrote:
>> Description: The patch creates a new sysfs entry framework for nbd.
>
> Why?  What does this buy us except an increase in code size for no added
> benifit?  You seem to be stripping out the driver layer here and using
> "raw" kobjects, why?

Not sure what I was thinking...just in a hurry, I think.

Is the following a little better?

Thanks for your feedback.

--
Paul

View attachment "tmp.diff" of type "text/x-patch" (3725 bytes)