linux-kernel - Re: [PATCH -mmotm] media: video/adp1653.c needs module.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110804102337.7a91f4d91d887ccd0168e4f8@canb.auug.org.au>
Date:	Thu, 4 Aug 2011 10:23:37 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	akpm@...ux-foundation.org, linux-media@...r.kernel.org,
	mchehab@...radead.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org,
	linux-next@...r.kernel.org
Subject: Re: [PATCH -mmotm] media: video/adp1653.c needs module.h

Hi Randy,

On Wed, 3 Aug 2011 10:12:26 -0700 Randy Dunlap <rdunlap@...otime.net> wrote:
>
> From: Randy Dunlap <rdunlap@...otime.net>
> 
> adp1653.c uses interfaces that are provided by <linux/module.h>
> and needs to include that header file to fix build errors.
> 
> drivers/media/video/adp1653.c:453: warning: data definition has no type or storage class
> drivers/media/video/adp1653.c:453: warning: parameter names (without types) in function declaration
> drivers/media/video/adp1653.c:474: error: 'THIS_MODULE' undeclared (first use in this function)
> and more.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...otime.net>

That is a bug that is now in Linus' tree and this fix is pending in the
moduleh tree in linux-next.  So this patch should go to Linus.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped