linux-kernel - Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E3A4904.3040007@ge.com>
Date:	Thu, 04 Aug 2011 08:23:48 +0100
From:	Martyn Welch <martyn.welch@...com>
To:	"Emilio G. Cota" <cota@...ap.org>
CC:	Manohar Vanga <manohar.vanga@...n.ch>, gregkh@...e.de,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/8] staging: vme: add functions for bridge module refcounting

On 03/08/11 16:23, Emilio G. Cota wrote:
> On Wed, Aug 03, 2011 at 16:06:30 +0200, Manohar Vanga wrote:
>> Hey Martyn,
>>
>>> Can we not do this inside vme_master_request, vme_slave_request, etc?
>>>
>>> I.e. Add reference count when resources are given out.
>>>
>>> This would then be done in the vme_*_free routines.
>>
>> I agree this would be much better. I will change this and resend :)
> 
> To me it seems better to keep this as is, to be
> used by .probe and .release methods, in the same way
> usb_get_dev() and usb_put_dev() are used by usb drivers.
> 

The description of the functions in usb.c suggests, to me at least, that these
functions are the equivalent to the vme_*_request functions in the vme code.
Being called when a function binds to an interface and when it is finished
with it.

Martyn

-- 
Martyn Welch (Principal Software Engineer) | Registered in England and
GE Intelligent Platforms                   | Wales (3828642) at 100
T +44(0)127322748                          | Barbirolli Square, Manchester,
E martyn.welch@...com                      | M2 3AB  VAT:GB 927559189
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/