linux-kernel - Re: [Xen-devel] Re: [PATCH -v3 2/3] xen-blkback: repleace check kthread_should_stop() to remove_requested in xen_blkif

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E3BBB00.1050101@cantab.net>
Date:	Fri, 05 Aug 2011 10:42:24 +0100
From:	David Vrabel <dvrabel@...tab.net>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	Joe Jin <joe.jin@...cle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	Greg Marsden <greg.marsden@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ian Campbell <Ian.Campbell@...citrix.com>,
	Annie Li <annie.li@...cle.com>,
	Kurt C Hackel <KURT.HACKEL@...cle.com>,
	Daniel Stodden <daniel.stodden@...rix.com>
Subject: Re: [Xen-devel] Re: [PATCH -v3 2/3] xen-blkback: repleace check kthread_should_stop()
 to remove_requested in xen_blkif_schedule() loop.

On 04/08/2011 20:48, Konrad Rzeszutek Wilk wrote:
> <sigh>  I can't believe I didn't catch this earlier, but this a
> big NO NO. Each patch _MUST_ be compile on its own. If I commit
> patch 1 and this patch, the compile (actually linker) process
> stops b/c xen_blkback_close is not defined:

All three patches should be merged together as patch 2 on it's own will 
break the driver as the thread will never exit as 
blkif->remove_requested isn't set until patch 3.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/