linux-kernel - Re: [PATCH] x86, olpc: Wait for last byte of EC command to be accepted

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110805104356.GA13055@elte.hu>
Date:	Fri, 5 Aug 2011 12:43:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Drake <dsd@...top.org>
Cc:	mingo@...hat.com, tglx@...utronix.de, hpa@...or.com,
	x86@...nel.org, dilinger@...ued.net, pgf@...top.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, olpc: Wait for last byte of EC command to be
 accepted


* Daniel Drake <dsd@...top.org> wrote:

> From: Paul Fox <pgf@...top.org>
> 
> When executing EC commands, only waiting when there are still more bytes to
> write is usually fine. However, if the system suspends very quickly after
> a call to olpc_ec_cmd(), the last data byte may not yet be transferred to
> the EC, and the command will not complete.
> 
> This solves a bug where the SCI wakeup mask was not correctly written
> when going into suspend.

What did that result in - a resume hang? (i.e. how urgent is this fix 
- v3.1 material or v3.2 material?)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/