linux-kernel - Re: Getting notification of PS/2 mouse packages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110805123605.GA5464@nautilus.holoscopio.com>
Date:	Fri, 5 Aug 2011 09:36:06 -0300
From:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
To:	Michael Thayer <michael.thayer@...cle.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Getting notification of PS/2 mouse packages

On Fri, Aug 05, 2011 at 01:35:55PM +0200, Michael Thayer wrote:
> Hello,
> 
> I am looking at writing a driver (it is to be open source, but not for
> mainstream kernel inclusion) for a virtual machine-specific input
> device.  Unfortunately one of the versions of the device I have to
> support signals that it has new data available by sending a fake package
> to the PS/2 mouse, so I need to be able to get notification of that
> somehow.  Looking at the kernel source, I see that the i8042 driver
> requests IRQ 12 as IRQF_SHARED, and that the kernel always notifies all
> registered interrupt handlers of an interrupt, even if one of them
> returns IRQ_HANDLED.  So it looks like I can just request my own shared
> handler for IRQ 12 and always return IRQ_NONE, but still update my data.
> However I am not sure whether this is something I can count on to keep
> working in future kernel releases.  Does anyone on this list know more
> about this, or can someone suggest a cleaner way to get the
> notifications I need?
> 
> Thanks.
> 
> Regards,
> 
> Michael

Hello, Michael.

My advice is: send it for mainline inclusion!

You more likely get your code reviewed, and it what you do is
acceptable, it will get included and that's a "OK" for your solution.
Then, if it turns out it's not OK anymore, it's much more likely people
will go and fix it for you. At least, that's certainly not going to
happen if it's not published somehow, but out-of-tree drivers or patches
do not usually have the attention of Linux developers.

So, what is it that you consider your work not worth of mainline
inclusion?

Regards,
Cascardo.

> -- 
> ORACLE Deutschland B.V. & Co. KG   Michael Thayer
> Werkstrasse 24                     VirtualBox engineering
> 71384 Weinstadt, Germany           mailto:michael.thayer@...cle.com
> 
> Hauptverwaltung: Riesstr. 25, D-80992 München
> Registergericht: Amtsgericht München, HRA 95603
> 
> Komplementärin: ORACLE Deutschland Verwaltung B.V.
> Hertogswetering 163/167, 3543 AS Utrecht, Niederlande
> Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697
> Geschäftsführer: Jürgen Kunz, Marcel van de Molen, Alexander van der Ven

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)