linux-kernel - Re: [PATCH] jump label: Reduce the cycle count by changing the link order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312582209.28695.51.camel@twins>
Date:	Sat, 06 Aug 2011 00:10:09 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Jason Baron <jbaron@...hat.com>
Cc:	rostedt@...dmis.org, pjt@...gle.com, mingo@...e.hu, rth@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jump label: Reduce the cycle count by changing the link
 order

On Fri, 2011-08-05 at 16:40 -0400, Jason Baron wrote:
> In the course of testing jump labels for use with the CFS bandwidth controller,
> Paul Turner, discovered that using jump labels reduced the branch count and the
> instruction count, but did not reduce the cycle count or wall time.
> 
> I noticed that having the jump_label.o included in the kernel but not used in
> any way still caused this increase in cycle count and wall time. Thus, I moved
> jump_label.o in the kernel/Makefile, thus changing the link order, and
> presumably moving it out of hot icache areas. This brought down the cycle
> count/time as expected.
> 
> In addition to Paul's testing,  I've tested the patch using a single
> 'static_branch()' in the getppid() path, and basically running tight loops of
> calls to getppid(). Here are my results for the branch disabled case:

Those numbers don't seem to be pre/post patch, but merely
CONFIG_JUMP_LABEL=y/n so they don't tell us what the patch does.

Anyway, should we put a comment in the Makefile telling us we should
keep jump_label.o last?

Also, pjt mentioned on IRC that mucking about with link order is
something google is not unfamiliar with.. could we use some sort of
runtime feedback to generate linker layout maps or so? That seems like a
more scalable version than randomly mucking about with Makefiles :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/