linux-kernel - Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110806015815.GA26833@dumpdata.com>
Date:	Fri, 5 Aug 2011 21:58:16 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	xen-devel@...ts.xensource.com, LKML <linux-kernel@...r.kernel.org>,
	virtualization@...ts.linux-foundation.org,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	linux-next@...r.kernel.org, "H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [Xen-devel] Re: linux-next: Tree for July 25 (xen)

On Fri, Aug 05, 2011 at 11:14:23PM +0200, Ingo Molnar wrote:
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > * Randy Dunlap <rdunlap@...otime.net> wrote:
> > 
> > > On 08/04/11 15:40, Konrad Rzeszutek Wilk wrote:
> > > > On Thu, Aug 04, 2011 at 06:32:59PM -0400, Konrad Rzeszutek Wilk wrote:
> > > >>>>> These build failures are still triggering upstream:
> > > >>>>>
> > > >>>>>  arch/x86/xen/trace.c:44:2: error: array index in initializer not of integer type
> > > >>>>>  arch/x86/xen/trace.c:44:2: error: (near initialization for ‘xen_hypercall_names’)
> > > >>>>>  arch/x86/xen/trace.c:45:1: error: ‘__HYPERVISOR_arch_4’ undeclared here (not in a function)
> > > >>>>>  arch/x86/xen/trace.c:45:2: error: array index in initializer not of integer type
> > > >>>>>  arch/x86/xen/trace.c:45:2: error: (near initialization for ‘xen_hypercall_names’)
> > > >>>>
> > > >>>> Oh, that I haven't seen. Can you send me the .config for that please.
> > > >>>
> > > >>> You can't be trying very hard then.  I see lots of these (but no,
> > > >>
> > > >> Ah, I am getting it now. Thanks for reporting it.
> > > > 
> > > > This should do the trick:
> > > 
> > > Acked-by: Randy Dunlap <rdunlap@...otime.net>
> > 
> > That patch did the trick here too:
> > 
> > Acked-by: Ingo Molnar <mingo@...e.hu>
> 
> Except that i'm still seeing the occasional build failure - see the 
> error log below. Config attached.

Much appreciate for the report. I believe this fix (which I think hit
linux-next yesterday?) should do that:

commit 1e9ea2656b656edd3c8de98675bbc0340211b5bd
Author: Jeremy Fitzhardinge <jeremy@...p.org>
Date:   Wed Aug 3 09:43:44 2011 -0700

     xen/tracing: it looks like we wanted CONFIG_FTRACE
    
    Apparently we wanted CONFIG_FTRACE rather the CONFIG_FUNCTION_TRACER.
    
    Reported-by: Sander Eikelenboom <linux@...elenboom.it>
    Tested-by: Sander Eikelenboom <linux@...elenboom.it>
    Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>

diff --git a/arch/x86/xen/Makefile b/arch/x86/xen/Makefile
index 45e94ac..3326204 100644
--- a/arch/x86/xen/Makefile
+++ b/arch/x86/xen/Makefile
@@ -15,7 +15,7 @@ obj-y		:= enlighten.o setup.o multicalls.o mmu.o irq.o \
 			grant-table.o suspend.o platform-pci-unplug.o \
 			p2m.o
 
-obj-$(CONFIG_FUNCTION_TRACER) += trace.o
+obj-$(CONFIG_FTRACE) += trace.o
 
 obj-$(CONFIG_SMP)		+= smp.o
 obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o


Planning to send all of the bug-fixes in my branch to Linus tomorrow - just
leaving it in linux-next for the full 24-hrs at least to make sure nothing
else goes haywire.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/