linux-kernel - Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hy5z79bx8.wl%tiwai@suse.de>
Date:	Sat, 06 Aug 2011 10:33:39 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Randy Dunlap <rdunlap@...otime.net>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-media@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	Ondrej Zary <linux@...nbow-software.org>
Subject: Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

At Fri, 5 Aug 2011 16:56:11 -0700,
Randy Dunlap wrote:
> 
> On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote:
> 
> > Hi all,
> > 
> > [The kernel.org mirroring is running slowly today]
> 
> Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver?
> ugh.  Or is it an I2C driver?
> 
> 
> linux-next fails with (this is not a new failure):
> 
> ERROR: "snd_tea575x_init" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> ERROR: "snd_tea575x_exit" [drivers/media/radio/radio-sf16fmr2.ko] undefined!
> 
> The Kconfig entry for RADIO_SF16FMR2 is:
> 
> config RADIO_SF16FMR2
> 	tristate "SF16FMR2 Radio"
> 	depends on ISA && VIDEO_V4L2 && SND
> 
> and the Kconfig entry for SND_TEA575X is (not user visible):
> 
> config SND_TEA575X
> 	tristate
> 	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
> 	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
> 
> This latter entry is in sound/pci/Kconfig and is under:
> if SND_PCI
> so it depends on PCI and SND_PCI.
> 
> This build fails when CONFIG_PCI is not enabled.

tea575x-tuner is an i2c component (not meaning Linux i2c-subsystem),
thus should be independent from the board bus type.
Does a patch like below work?


thanks,

Takashi

---
diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig
index 50abf5b..8816804 100644
--- a/sound/pci/Kconfig
+++ b/sound/pci/Kconfig
@@ -1,5 +1,10 @@
 # ALSA PCI drivers
 
+config SND_TEA575X
+	tristate
+	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
+	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
+
 menuconfig SND_PCI
 	bool "PCI sound devices"
 	depends on PCI
@@ -563,11 +568,6 @@ config SND_FM801_TEA575X_BOOL
 	  FM801 chip with a TEA5757 tuner (MediaForte SF256-PCS, SF256-PCP and
 	  SF64-PCR) into the snd-fm801 driver.
 
-config SND_TEA575X
-	tristate
-	depends on SND_FM801_TEA575X_BOOL || SND_ES1968_RADIO || RADIO_SF16FMR2
-	default SND_FM801 || SND_ES1968 || RADIO_SF16FMR2
-
 source "sound/pci/hda/Kconfig"
 
 config SND_HDSP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/