linux-kernel - Re: [Patch] cpupower: avoid using symlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 6 Aug 2011 12:34:16 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	Dominik Brodowski <linux@...inikbrodowski.net>,
	Thomas Renninger <trenn@...e.de>
Subject: Re: [Patch] cpupower: avoid using symlinks

Hi,

On Wed, Aug 3, 2011 at 1:17 AM, Amerigo Wang <amwang@...hat.com> wrote:
> Reference the source directly, don't create symlinks.
>
> Signed-off-by: WANG Cong <amwang@...hat.com>
>
> ---
> diff --git a/tools/power/cpupower/debug/x86_64/Makefile b/tools/power/cpupower/debug/x86_64/Makefile
> index dbf1399..3326217 100644
> --- a/tools/power/cpupower/debug/x86_64/Makefile
> +++ b/tools/power/cpupower/debug/x86_64/Makefile
> @@ -1,10 +1,10 @@
>  default: all
>
> -centrino-decode: centrino-decode.c
> -       $(CC) $(CFLAGS) -o centrino-decode centrino-decode.c
> +centrino-decode: ../i386/centrino-decode.c
> +       $(CC) $(CFLAGS) -o $@ $<
>
> -powernow-k8-decode: powernow-k8-decode.c
> -       $(CC) $(CFLAGS) -o powernow-k8-decode powernow-k8-decode.c
> +powernow-k8-decode: ../i386/powernow-k8-decode.c
> +       $(CC) $(CFLAGS) -o $@ $<
>
>  all: centrino-decode powernow-k8-decode
>
Is there any reason for this stuff not to use kbuild ?

Thanks,
 - Arnaud

> diff --git a/tools/power/cpupower/debug/x86_64/centrino-decode.c b/tools/power/cpupower/debug/x86_64/centrino-decode.c
> deleted file mode 120000
> index 26fb3f1..0000000
> --- a/tools/power/cpupower/debug/x86_64/centrino-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/centrino-decode.c
> \ No newline at end of file
> diff --git a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c b/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> deleted file mode 120000
> index eb30c79..0000000
> --- a/tools/power/cpupower/debug/x86_64/powernow-k8-decode.c
> +++ /dev/null
> @@ -1 +0,0 @@
> -../i386/powernow-k8-decode.c
> \ No newline at end of file
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/