linux-kernel - Re: [PATCH] ALSA: asihpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr54x9qyq.wl%tiwai@suse.de>
Date:	Sun, 07 Aug 2011 17:33:17 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: asihpi - use kzalloc()

At Sat, 06 Aug 2011 13:26:20 +0200,
Thomas Meyer wrote:
> 
> From: Thomas Meyer <thomas@...3r.de>
> 
> 
>  Use kzalloc rather than kmalloc followed by memset with 0
> 
>  This considers some simple cases that are common and easy to validate
>  Note in particular that there are no ...s in the rule, so all of the
>  matched code has to be contiguous
> 
>  The semantic patch that makes this output is available
>  in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
> 
>  More information about semantic patching is available at
>  http://coccinelle.lip6.fr/
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

Applied now.  Thanks.


Takashi


> ---
> 
> diff -u -p a/sound/pci/asihpi/hpicmn.c b/sound/pci/asihpi/hpicmn.c
> --- a/sound/pci/asihpi/hpicmn.c 2011-07-26 00:46:12.970154018 +0200
> +++ b/sound/pci/asihpi/hpicmn.c 2011-08-01 20:42:34.859285236 +0200
> @@ -631,13 +631,12 @@ struct hpi_control_cache *hpi_alloc_cont
>  	if (!p_cache)
>  		return NULL;
>  
> -	p_cache->p_info =
> -		kmalloc(sizeof(*p_cache->p_info) * control_count, GFP_KERNEL);
> +	p_cache->p_info = kzalloc(sizeof(*p_cache->p_info) * control_count,
> +				  GFP_KERNEL);
>  	if (!p_cache->p_info) {
>  		kfree(p_cache);
>  		return NULL;
>  	}
> -	memset(p_cache->p_info, 0, sizeof(*p_cache->p_info) * control_count);
>  	p_cache->cache_size_in_bytes = size_in_bytes;
>  	p_cache->control_count = control_count;
>  	p_cache->p_cache = p_dsp_control_buffer;
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/