linux-kernel - Re: list corruption in the last few days. (block ? crypto ?)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzdp+7+AcCFbx3dCkfqERzYvOZG3c3SUuNAw+X0MJ8iNw@mail.gmail.com>
Date:	Sun, 7 Aug 2011 14:13:41 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Pekka Enberg <penberg@...nel.org>
Cc:	Dave Jones <davej@...hat.com>, Christoph Lameter <cl@...ux.com>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jens Axboe <jaxboe@...ionio.com>
Subject: Re: list corruption in the last few days. (block ? crypto ?)

On Sun, Aug 7, 2011 at 11:58 AM, Pekka Enberg <penberg@...nel.org> wrote:
>
> Christoph, I've been reading the code and spotted two potential issues in
> __slab_free(). The first one seems like an off-by-one where our comparison
> in deactivate_slab() doesn't match __slab_free.
>
> The other one is remove_full() call in __slab_free() that can get called
> even if cache debugging is not enabled.
>
> Hmm?

I'd like to do -rc1 today, regardless of whether this fixes things or
not (-rc1 is already a few days delayed).

The patch seems to be a good fix, and a likely candidate for the
corruption. Commit log and sign-off? I assume you've given it some
testing, even if you couldn't reproduce the original issue?

                          Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/